Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caddy: 0.9.2 -> 0.9.5 (backport) #22544

Merged
merged 1 commit into from Feb 16, 2017
Merged

caddy: 0.9.2 -> 0.9.5 (backport) #22544

merged 1 commit into from Feb 16, 2017

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 8, 2017

Motivation for this change

As requested by @davidak in #22119

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@rnhmjoj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kamilchm and @rushmorem to be potential reviewers.

@rnhmjoj rnhmjoj changed the title caddy: 0.9.2 -> 0.9.5 caddy: 0.9.2 -> 0.9.5 (backport) Feb 8, 2017
@davidak davidak mentioned this pull request Feb 8, 2017
Closed
@davidak
Copy link
Member

davidak commented Feb 9, 2017 •
edited

Travis: "The repository at NixOS/nixpkgs was not found."

@rnhmjoj thanks!

I tried to build it on OS X 10.10.5, NixOS 16.03 and elementary OS 0.4 (based on Ubuntu 16.04) but it failed.

I used nix-shell -p nox --run "nox-review pr 22544"

https://gist.github.com/davidak/3d9769674519ea69993236650658cd7c
https://gist.github.com/davidak/d5f47d2c2f61ee7ca1a7af71dcbaa6e1
https://gist.github.com/davidak/4692867cc90a9ee842ec84b669360013

@davidak davidak mentioned this pull request Feb 15, 2017
Closed
@davidak
Copy link
Member

davidak commented Feb 15, 2017

I checked out this PR on NixOS and rebuilt the system with it without errors. So this was probably an error of nox.

That go-1.4-bootstrap don't build on OS X is a different issue.

👍 So good to merge i guess.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 15, 2017

Yes, the package builds for me on a NixOS 16.09 vm but nox review fails.

@grahamc grahamc merged commit c1f2331 into NixOS:release-16.09 Feb 16, 2017
@rnhmjoj rnhmjoj deleted the caddy-backport branch September 12, 2017 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rnhmjoj @mention-bot @davidak @grahamc @pSub