Hiawatha: Init at 10.5 #22916
Hiawatha: Init at 10.5 #22916
Conversation
Hiawatha: Fixed missing pkg tag new file: pkgs/servers/http/hiawatha/default.nix hiawatha: 10.5 module modified: nixos/modules/misc/ids.nix modified: pkgs/servers/http/hiawatha/default.nix modified: nixos/modules/misc/ids.nix modified: nixos/modules/module-list.nix new file: nixos/modules/services/web-servers/hiawatha.nix new file: pkgs/servers/http/hiawatha/default.nix modified: pkgs/top-level/all-packages.nix
| @@ -13738,6 +13738,8 @@ with pkgs; | |||
|
|
|||
| hexedit = callPackage ../applications/editors/hexedit { }; | |||
|
|
|||
| hiawatha = callPackage ../servers/http/hiawatha { }; | |||
There was a problem hiding this comment.
Could you move this to the "### SERVERS" section instead, please:
https://github.com/ndowens/nixpkgs/blob/eb232b63ee6b6bb5d2b437694afa0ad1f2617c33/pkgs/top-level/all-packages.nix#L10239
After hbase:
https://github.com/ndowens/nixpkgs/blob/eb232b63ee6b6bb5d2b437694afa0ad1f2617c33/pkgs/top-level/all-packages.nix#L10410
Thanks!
There was a problem hiding this comment.
I will once I get home
| meta = with stdenv.lib; { | ||
| description = "An advanced and secure webserver"; | ||
| license = licenses.gpl2; | ||
| homepage = "https://www.hiawatha-webserver.org"; |
There was a problem hiding this comment.
Could you add yourself as a maintainer? You need to include your details in /lib/maintainers.nix too.
There was a problem hiding this comment.
Ah, I see you're already in maintainers.nix :)
There was a problem hiding this comment.
Yeah I am in the list already 😀 Surprised I left out that line.
|
Gonna close it and open another; messed up with git |
Motivation for this change
Add hiawatha to repo
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)