Skip to content

Commit

Permalink
fakechroot: 2.17.2 -> 2.19 (with modification)
Browse files Browse the repository at this point in the history
There's a PR I need merged so this is currently pointing at a fork
on my GitHub but I'll repoint it to mainline once that gets merged.
  • Loading branch information
copumpkin committed Feb 17, 2017
1 parent bd0d8ed commit 7a113e9
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions pkgs/tools/system/fakechroot/default.nix
@@ -1,14 +1,19 @@
{stdenv, fetchurl}:
{ stdenv, fetchFromGitHub, autoreconfHook, perl }:

stdenv.mkDerivation rec {
name = "fakechroot-${version}";
version = "2.17.2";
version = "2.19";

src = fetchurl {
url = "https://github.com/dex4er/fakechroot/archive/${version}.tar.gz";
sha256 = "0z4cxj4lb8cfb63sw82dbc31hf082fv3hshbmhk49cqkc0f673q3";
# TODO: move back to mainline once https://github.com/dex4er/fakechroot/pull/46 is merged
src = fetchFromGitHub {
owner = "copumpkin";
repo = "fakechroot";
rev = "dcc0cfe3941e328538f9e62b2c0b15430d393ec1";
sha256 = "1ls3y97qqfcfd3z0balz94xq1gskfk04pg85x6b7wjw8dm4030qd";
};

buildInputs = [ autoreconfHook perl ];

meta = with stdenv.lib; {
homepage = https://github.com/dex4er/fakechroot;
description = "Give a fake chroot environment through LD_PRELOAD";
Expand Down

4 comments on commit 7a113e9

@copumpkin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @offlinehacker since you're listed as a maintainer

@globin
Copy link
Member

@globin globin commented on 7a113e9 Feb 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have preferred this:

patches = [
  (fetchpatch {
    url = "https://github.com/dex4er/fakechroot/pull/46.patch";
    sha256 = "...";
  })
]

@copumpkin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could easily do that if it's a strong preference 😄

@globin
Copy link
Member

@globin globin commented on 7a113e9 Feb 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, just for the future :)

Please sign in to comment.