ocaml-angstrom: init at 0.3.0 #22921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sternenseemann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aske, @vbgl and @volth to be potential reviewers. |
vbgl
requested changes
Feb 18, 2017
|
|
||
| buildInputs = [ ocaml ocaml_oasis findlib ocplib-endian ]; | ||
| propagatedBuildInputs = [ result cstruct ]; | ||
|
|
There was a problem hiding this comment.
ocplib-endian is already propagated by cstruct, so not needed here.
| meta = { | ||
| homepage = https://github.com/inhabitedtype/angstrom; | ||
| description = "Parser combinators built for speed and memory efficiency"; | ||
| license = stdenv.license.bsd3; |
There was a problem hiding this comment.
There is no stdenv.license attribute, but there is a stdenv.lib.licenses one.
sternenseemann
force-pushed
the
angstrom
branch
from
1b23a03
to
21ad865
Compare
|
@vbgl Thanks for your review! I have fixed your points. |
sternenseemann
force-pushed
the
angstrom
branch
from
21ad865
to
bb101fc
Compare
sternenseemann
force-pushed
the
angstrom
branch
from
bb101fc
to
6809c93
Compare
vbgl
approved these changes
Feb 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)