ghcWithHoogle: fix for ghcjs #22805
Merged
ghcWithHoogle: fix for ghcjs #22805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`haskell.packages.ghcjs.ghcWithHoogle` failed because the following line:
for docdir in ${ghc.doc}/${docLibGlob}/*; do
failed because `doc` is not an attribute of `ghc` when `ghc` is
substituted for ghcjs.
|
@basvandijk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @oxij, @cstrahan and @Profpatsch to be potential reviewers. |
|
@peti thanks for the merge! Can we get the fix on 16.09 to please? |
peti
added a commit
that referenced
this pull request
Feb 15, 2017
ghcWithHoogle: fix for ghcjs (cherry picked from commit cb2499a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peti
haskell.packages.ghcjs.ghcWithHooglefailed because the following line:failed because
docis not an attribute ofghcwhenghcis substituted for ghcjs.Since this problem also exists on 16.09 it would be great if this patch can be cherry-picked on
release-16.09.