open-vm-tools: build vmhgfs-fuse #22364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jekor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @osmano807 and @joamaki to be potential reviewers. |
|
Oh nice! Does this affect the module somehow? |
|
The module was not being built previously ( |
|
Sorry I meant the NixOS config module. Does anything need to change there?
Or if not, how does one use this?
…On Fri, Feb 3, 2017 at 03:27 Chris Forno ***@***.***> wrote:
The module was not being built previously (--without-kernel-modules in
the configure flags) and that hasn't changed, if that's what you're asking.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#22364 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAKPwypCkr7_IwVgoGle0nSauBW0F2Cks5rYpCTgaJpZM4L0zDX>
.
|
|
Ah, right. You end up with another binary: I'm not sure how to tie that in to configuring mount points (if that's desirable). |
fpletz
approved these changes
Feb 21, 2017
|
That seems to be covered by master changes by now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
open-vm-tools has switched from a kernel module to fuse for vmhgfs (shared folders) in version 10. Adding fuse as a build dependency so that vmhgfs-fuse gets built.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)