[WIP] clementine-qt5: init at 1.3.1 - call for testers #22366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ttuegel are you OK to merge this in its current incarnation? |
ttuegel
requested changes
Feb 12, 2017
|
|
||
| runCommand "clementine-${version}" { | ||
| inherit free blob; | ||
| buildInputs = [ makeWrapper ] ++ gst_plugins; # for the setup-hooks |
There was a problem hiding this comment.
This should use makeQtWrapper here and below. Since it has KDE 5 dependencies, you also need ecm here for the setup hooks.
| ${optionalString withSpotify "--set CLEMENTINE_SPOTIFYBLOB \"$blob/libexec/clementine\""} \ | ||
| --prefix GST_PLUGIN_SYSTEM_PATH : "$GST_PLUGIN_SYSTEM_PATH" | ||
|
|
||
| mkdir -p $out/share |
There was a problem hiding this comment.
Adding ecm to buildInputs and using makeQtWrapper should make this unnecessary.
|
@ttuegel, couple of things: Now the qt4 and qt5 versions are both compiling and launching correctly at the latest version (1.3.1) but they are both crashing on playback with a gstreamer assertion (see clementine-player/Clementine#5753).
|
peterhoeg
force-pushed
the
u/clementine
branch
2 times, most recently
from
d41fe33
to
dc059fd
Compare
Also update 1.2.3 -> 1.3.1 for the qt4 version. Currently crashes when trying to play any file which I guess is related to gstreamer.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Running qt4 applications on a hidpi screen isn't always a great experience.
Clementine based on qt5 has been in the works for some time.
Known issue:
While clementine is supposedly cross platform, the port to qt5 only works on
linux for now but upstream is working on it.
I'd love to hear some feedback from testers before we actually merge this.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)