Implement String#casecmp?
and Symbol#casecmp?
#4470
Merged
+38
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
casecmp?
based on downcasing the string and comparingcasecmp?
from MRIThere is a test failing in each of the tests (the last assertion in each method) I brought over. This is because the MRI implementation (ruby/ruby@ad619e0) of
casecmp?
relies on passing the:fold
option todowncase
however that option has not been added yet in JRuby. It is referenced in #4293 though.I decided to keep the failing tests in for completeness since they will need to be fixed anyway for 2.4 support. I figured that this PR would be fine without those specific cases supported but maybe it would be better to wait until
:fold
is implemented.See #4293