Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lumail: init at 2.9 #22841

Merged
merged 2 commits into from Feb 17, 2017
Merged

lumail: init at 2.9 #22841

merged 2 commits into from Feb 17, 2017

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Feb 15, 2017

Motivation for this change

This adds a console Mailbox and IMAP email client Lumail.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@thufschmitt
Copy link
Member

You probably should split it into two commits.
Otherwise it looks fine to me

@orivej
Copy link
Contributor Author

orivej commented Feb 17, 2017

OK, split.

@globin globin merged commit 47ded42 into NixOS:master Feb 17, 2017
@orivej orivej deleted the lumail branch February 17, 2017 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @thufschmitt @globin