better subprocess tests

mojolicious · Feb 15, 2017 · 15be7c7 · 15be7c7
1 parent 2d2eb4f
commit 15be7c7
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 13 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,7 @@
 
 7.26  2017-02-15
+  - Fixed bug in Mojo::IOLoop::Subprocess where starting multiple subprocesses
+    at once could cause expcetions. (jberger)
 
 7.25  2017-02-09
   - Fixed cleanup bugs in Mojo::IOLoop::Stream.

diff --git a/t/mojo/subprocess.t b/t/mojo/subprocess.t
@@ -107,6 +107,28 @@ Mojo::IOLoop->start;
 ok !$fail, 'no error';
 is_deeply $result, [], 'right structure';
 
+# Stream inherited from previous subprocesses
+($fail, $result) = ();
+my $delay = Mojo::IOLoop->delay;
+my $me    = $$;
+for (0 .. 2) {
+  my $end        = $delay->begin;
+  my $subprocess = Mojo::IOLoop::Subprocess->new;
+  $subprocess->run(
+    sub { 1 + 1 },
+    sub {
+      my ($subprocess, $err, $two) = @_;
+      $fail ||= $err;
+      push @$result, $two;
+      is $me, $$, 'we are the parent';
+      $end->();
+    }
+  );
+}
+$delay->wait;
+ok !$fail, 'no error';
+is_deeply $result, [2, 2, 2], 'right structure';
+
 # Exception
 $fail = undef;
 Mojo::IOLoop::Subprocess->new->run(
@@ -145,17 +167,4 @@ $subprocess->run(
 Mojo::IOLoop->start;
 like $fail, qr/Whatever/, 'right error';
 
-# Stream inherited by previous subprocesses, #1054
-my $me = $$;
-for (0 .. 2) {
-  my $subprocess = Mojo::IOLoop::Subprocess->new;
-  $subprocess->run(
-    sub { 1 + 1 },
-    sub {
-      my ($subprocess, $err) = @_;
-      is $me, $$, 'correct parent';
-    }
-  );
-}
-
 done_testing();