Fix Enum#to_s to wrap flag enums with parens
#3961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example:
@[Flags]
enum Foo
A
B
end
p [Foo::A, Foo::B, Foo::A | Foo::B]
It outpus:
[A, B, A, B]
This output is ambigious, so this commit fixes it to wrap multiple flag
enums with parens:
[A, B, (A, B)]
|
WDYT about adding a |
|
|
|
I would think about piping possibilities, instead of surrounding them with parens: I find it more consistent with how you write it in code |
|
I agree for a pipe, it better represents the underlying value, and avoids the issue altogether. |
|
Honestly, I thought same thing at first, but also I need to respect current implementation, so I fixed as this way. |
makenowjust
added a commit
to makenowjust/crystal
that referenced
this pull request
Feb 6, 2017
Use pipe `|` instead of `,`. Fix crystal-lang#3961.
|
Closed in favor of #4005 |
bcardiff
pushed a commit
that referenced
this pull request
Feb 9, 2017
Use pipe `|` instead of `,`. Fix #3961.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes is to display multiple enum flags in collection. For example:
It outpus:
This output is ambigious, so this commit fixes it to wrap multiple flag enums with parens. Then, it outputs:
It looks good. Thanks.