vim: make it possible to build with --enable-gui=gtk3 #22309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't change any defaults; I suspect that dropping gtk2 support would annoy some people so I didn't want to do that without asking around first.
|
@benley, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MarcWeber, @Mathnerd314 and @vcunat to be potential reviewers. |
fpletz
approved these changes
Jan 31, 2017
vcunat
approved these changes
Jan 31, 2017
vcunat
added a commit
that referenced
this pull request
Jan 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change any defaults; I suspect that dropping gtk2 support
would annoy some people so I didn't want to do that without asking
around first.
Motivation for this change
gtk2 has no support for scalable UI elements, which makes life unpleasant on high-dpi displays. Building with gtk3 support makes it much nicer.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)