keepalived: 1.2.19 -> 1.3.2 #22754
keepalived: 1.2.19 -> 1.3.2 #22754
Conversation
|
@mbrgm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @dezgeg and @bjornfor to be potential reviewers. |
| }; | ||
|
|
||
| buildInputs = [ openssl net_snmp libnl ]; | ||
| buildInputs = [ openssl ]; |
There was a problem hiding this comment.
Does passing pkgconfig here, allow removal of the preConfigure export of PKG_CONFIG?
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "keepalived-1.2.19"; | ||
| name = "keepalived-${version}"; | ||
| version = "1.3.2"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
fetchFromGitHub may be a better option here since it is more specialized.
mbrgm
force-pushed
the
update-keepalived
branch
from
7921012
to
e8cd22e
Compare
|
Verified on NixOS Linux. I think this PR is ready for merging. |
| @@ -1,33 +1,17 @@ | |||
| { stdenv, fetchurl, openssl, net_snmp, libnl }: | |||
There was a problem hiding this comment.
Why did you remove support libnl and net_snmp? Sounds generally useful to me. Though libnl should only be enabled if this is built on Linux. This package is Linux-only.
| installFlags = [ | ||
| "sysconfdir=\${out}/etc" | ||
| ]; | ||
| buildInputs = [ openssl pkgconfig ]; |
There was a problem hiding this comment.
pkgconfig should be in nativeBuildInputs.
mbrgm
force-pushed
the
update-keepalived
branch
from
e8cd22e
to
b8ce13a
Compare
mbrgm
force-pushed
the
update-keepalived
branch
from
b8ce13a
to
4ebfc19
Compare
|
Looks like all review comments have been attended to, including the |
No description provided.