Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/geoip-updater: run as user 'geoip' instead of 'nobody' #22762

Merged
merged 1 commit into from Feb 15, 2017

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

That way 'nobody' is prevented from messing with the databases.

Suggested by @abbradar.
CC @danbst

WARNING: Not tested yet because master branch is broken.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@bjornfor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @joachifm and @abbradar to be potential reviewers.

That way 'nobody' is prevented from messing with the databases.
@bjornfor bjornfor merged commit d4e5bb3 into NixOS:master Feb 15, 2017
@bjornfor bjornfor deleted the geoip-service-user branch February 15, 2017 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants