Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mosh: use ssh from nixpkgs #22235

Merged
merged 1 commit into from Jan 29, 2017
Merged

mosh: use ssh from nixpkgs #22235

merged 1 commit into from Jan 29, 2017

Conversation

aneeshusa
Copy link
Contributor

Motivation for this change

Improve purity of mosh.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

kevincox
kevincox approved these changes Jan 28, 2017
View reviewed changes
Copy link
Contributor

@kevincox kevincox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@NeQuissimus NeQuissimus merged commit 58dcda6 into NixOS:master Jan 29, 2017
@aneeshusa aneeshusa deleted the mosh-use-ssh-from-nixpkgs branch January 7, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincox kevincox kevincox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aneeshusa @kevincox @NeQuissimus