Plantlike: Fix visual_scale being applied squared (#5115)

paramat · Zeno- · commit 953cbb3b1599 · 2017-01-28T20:07:35.000+10:00
Visual_scale was applied twice to plantlike by accident sometime between
2011 and 2013, squaring the requested scale value. Visual_scale is
correctly applied once in it's other uses in signlike and torchlike.

Two lines of code are removed, they also had no effect for the vast
majority of nodes with the default visual_scale of 1.0.
The texture continues to have it's base at ground level.
diff --git a/src/content_mapblock.cpp b/src/content_mapblock.cpp
@@ -1602,8 +1602,6 @@ void mapblock_mesh_generate_special(MeshMakeData *data,
 				}
 
 				for (int i = 0; i < 4; i++) {
-					vertices[i].Pos *= f.visual_scale;
-					vertices[i].Pos.Y += BS/2 * (f.visual_scale - 1);
 					if (data->m_smooth_lighting)
 						vertices[i].Color = blendLight(frame, vertices[i].Pos, tile.color);
 					vertices[i].Pos += intToFloat(p, BS);

Original file line number	Diff line number	Diff line change
`@@ -1602,8 +1602,6 @@ void mapblock_mesh_generate_special(MeshMakeData *data,`
`1602`	`1602`	`}`
`1603`	`1603`
`1604`	`1604`	`for (int i = 0; i < 4; i++) {`
`1605`		`- vertices[i].Pos *= f.visual_scale;`
`1606`		`- vertices[i].Pos.Y += BS/2 * (f.visual_scale - 1);`
`1607`	`1605`	`if (data->m_smooth_lighting)`
`1608`	`1606`	`vertices[i].Color = blendLight(frame, vertices[i].Pos, tile.color);`
`1609`	`1607`	`vertices[i].Pos += intToFloat(p, BS);`