Revert "libmsgpack_1_4: remove" #22226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ff89e81. There are references to this variable.
kevincox
added
0.kind: bug
0.kind: regression
|
I suggest we revert now and then we can look into proper removal in a later PR. |
|
@vcunat You seem to have been active recently, can I can approval to push this now? |
|
neovim-qt is the remaining consumer of 1.4; it builds and appears to run with msgpack 2 here. @7c6f434c might know more about why neovim-qt was configured to build against 1.4. |
vcunat
added a commit
that referenced
this pull request
Jan 28, 2017
Let's remove after all referrers are resolved.
|
Sorry missed that one, I'll check that again, and thanks for reverting in the meantime |
|
No problem. Hopefully we can kill it soon :) |
|
Most likely I just went with whatever was recommended for the specific version of NeoVim. I guess there has been an update of NeoVim since then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ff89e81.
Motivation for this change
There are references to this variable.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)