Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geogebra: 5.0.271.0 -> 5-0-320-0 #22231

Merged
merged 1 commit into from Feb 3, 2017
Merged

geogebra: 5.0.271.0 -> 5-0-320-0 #22231

merged 1 commit into from Feb 3, 2017

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 28, 2017 •
edited

Motivation for this change

download.geogebra.org doesn't provide version 5.0.271.0 anymore, so the installation ends up in a 404.
Furthermore they changed the dots to dashes (http://download.geogebra.org/installers/5.0/)

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Ma27, thanks for your PR! By analyzing the history of the files in this pull request, we identified @obadz and @moyamo to be potential reviewers.

@Ma27
Copy link
Member Author

Ma27 commented Jan 29, 2017

btw if this gets merged, will this be backported to 16.09?
(this breaks with a 404 on 16.09 as well)

@fpletz fpletz added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 29, 2017
@joachifm joachifm merged commit 2b96107 into NixOS:master Feb 3, 2017
joachifm pushed a commit that referenced this pull request Feb 3, 2017
@Ma27 @joachifm
geogebra: 5.0.271.0 -> 5-0-320-0
e67d70f 
(cherry picked from commit eda5bca)

Older versions are 404, see #22231
@joachifm
Copy link
Contributor

joachifm commented Feb 3, 2017

Merged & picked to release. Thank you

@Ma27 Ma27 deleted the hotfix/update-geogebra branch February 10, 2017 21:22
@Ma27 Ma27 mentioned this pull request Feb 14, 2017
Merged
7 tasks
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincox kevincox kevincox approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Ma27 @mention-bot @joachifm @kevincox @pSub @fpletz @samueldr @Janik-Haag