glpk: 4.56 -> 4.61 #22227
Merged
glpk: 4.56 -> 4.61 #22227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://lists.gnu.org/archive/html/info-gnu/2017-01/msg00011.html for release announcement
|
This appears to break octave on travis due to a linker error. Did you have different results when running locally? |
|
I did build it fine. I’ll relaunch the build to be sure. |
|
I can run: $ nix-shell -p nox --command 'nox-review pr 22227'
=== Reviewing PR 22227 : glpk: 4.56 -> 4.61
==> Fetching base (master)
[…]
/nix/store/xi00s2zvcaydj4xsq2v507gyw92v01sk-octave-4.2.0
/nix/store/m17sd5wxd7fyvy8wli5x00dj0spisclj-pure-glpk-0.5
/nix/store/l3zr2kwawc1qdbh46ljc8mcn2b174mv3-glpk-4.61
Result in /run/user/1000/nox-review-8ssmd2_a
total 0
lrwxrwxrwx 1 lsix lsix 56 29 janv. 17:30 result -> /nix/store/xi00s2zvcaydj4xsq2v507gyw92v01sk-octave-4.2.0
lrwxrwxrwx 1 lsix lsix 57 29 janv. 17:30 result-2 -> /nix/store/m17sd5wxd7fyvy8wli5x00dj0spisclj-pure-glpk-0.5
lrwxrwxrwx 1 lsix lsix 53 29 janv. 17:30 result-3 -> /nix/store/l3zr2kwawc1qdbh46ljc8mcn2b174mv3-glpk-4.61
$ /nix/store/xi00s2zvcaydj4xsq2v507gyw92v01sk-octave-4.2.0/bin/octave --version
octave: X11 DISPLAY environment variable not set
octave: disabling GUI features
GNU Octave, version 4.2.0
Copyright (C) 2016 John W. Eaton and others.
This is free software; see the source code for copying conditions.
There is ABSOLUTELY NO WARRANTY; not even for MERCHANTABILITY or
FITNESS FOR A PARTICULAR PURPOSE.
Octave was configured for "x86_64-pc-linux-gnu".
Additional information about Octave is available at http://www.octave.org.
Please contribute if you find this software useful.
For more information, visit http://www.octave.org/get-involved.html
Read http://www.octave.org/bugs.html to learn how to submit bug reports. |
LnL7
approved these changes
Feb 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://lists.gnu.org/archive/html/info-gnu/2017-01/msg00011.html
for release announcement
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)