Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NixOS: Respect nixpkgs.overlays #22221

Merged
merged 1 commit into from Jan 31, 2017
Merged

NixOS: Respect nixpkgs.overlays #22221

merged 1 commit into from Jan 31, 2017

Conversation

aneeshusa
Copy link
Contributor

Motivation for this change

I just tried switching from packageOverrides to overlays; they took effect for nixpkgs but not NixOS. Pass through the overlays parameter in the NixOS module.

cc @nbp

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@aneeshusa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @nbp and @urkud to be potential reviewers.

@aneeshusa
Copy link
Contributor Author

This seems to have been missed in #21243.

nbp
nbp approved these changes Jan 28, 2017
View reviewed changes
Copy link
Member

@nbp nbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, apparently I added the option without forwarding it to the nixpkgs call.

@nbp nbp added this to the 17.03 milestone Jan 28, 2017
@fpletz fpletz merged commit 68b4a1f into NixOS:master Jan 31, 2017
@aneeshusa aneeshusa deleted the respect-nixpkgs.overlays-for-nixos branch January 7, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp nbp approved these changes

@rasendubi rasendubi rasendubi approved these changes

Assignees
No one assigned
Labels
0.kind: bug 6.topic: nixos 8.has: module (update)
Projects
None yet
Milestone
17.03
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aneeshusa @mention-bot @nbp @rasendubi @fpletz