mathcomp 1.6.1 and related fixes #22223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeping old 2.1.1 version for Coq-8.4, as newer versions of the library do not support older Coq versions
Closed
kevincox
approved these changes
Jan 28, 2017
|
I'm on NixOS and I can confirm that I can now run successfully the command: which was failing with Coq 8.6 and Math-Comp 1.6.1 before this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The Coq libraries mathcomp, coquelicot, and interval are currently broken in
nixpkgswith Coq-8.6.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)The
mathcompfix is as follows: themathcompinstall keeps its own copy of thessreflectlibrary (and therefore no longer uses it as input nor propagates it). This seems wrong, but I tested theintervallibrary which depends on bothmathcomp(directly) andssreflect(throughcoquelicot) and that worked.