Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luaPackages.luazlib: fix on darwin #22306

Merged
merged 2 commits into from Feb 1, 2017
Merged

luaPackages.luazlib: fix on darwin #22306

merged 2 commits into from Feb 1, 2017

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jan 31, 2017

Motivation for this change

luaPackage.luazlib on master does not build on Darwin. Error: gcc: command not found

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

It does not build with luajit (error: ld: library not found for -llua). This can be fixed by changing llua into lluajit-5.1 in the Makefile; but then non-luajit builds get broken.

@mention-bot
Copy link

@vbgl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Wyvie, @vcunat and @flosse to be potential reviewers.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Jan 31, 2017
@vcunat
Copy link
Member

vcunat commented Jan 31, 2017 •
edited

/cc maintainer @k0ral. Instead of trying to patch it, I'd prefer trying an update 0.4 -> 1.1.

@vbgl
Copy link
Contributor Author

vbgl commented Jan 31, 2017

Thanks for the suggestion, Vladimír. Unfortunately, it seems that updating does not help: the Makefile did not apparently change between versions 0.4 and 1.1.

However, removing the -llua from the Makefile makes the build go through for all three lua versions (on darwin; let’s see what travis says for linux).

@vcunat
Copy link
Member

vcunat commented Jan 31, 2017

I tested locally that on x86_64-linux all three versions do build.

@vbgl
Copy link
Contributor Author

vbgl commented Feb 1, 2017

Thanks for testing.

@vbgl vbgl merged commit 7ace1b1 into NixOS:master Feb 1, 2017
@vbgl vbgl deleted the luazlib-darwin branch September 4, 2017 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vbgl @mention-bot @vcunat @LnL7