Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDE 5 packaging instructions #22902

Merged
merged 3 commits into from Feb 18, 2017
Merged

KDE 5 packaging instructions #22902

merged 3 commits into from Feb 18, 2017

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Feb 17, 2017

Problem

The instructions for adding and updating KDE 5 packages were significantly out-of-date. Consequently, there were mistakes in several package updates or additions.

Solution

  1. The instructions are made current.
  2. The mistaken package updates and additions are corrected.

Testing

I have verified, using nox-review, that these changes do not cause any rebuilds.

This change makes additional versions of libktorrent available, verified with nox-review.

Builds:

  • NixOS with sandboxing
  • macOS (Travis)
  • Other Linux

@mention-bot
Copy link

@ttuegel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vandenoever, @dezgeg and @groxxda to be potential reviewers.

@ttuegel
Copy link
Member Author

ttuegel commented Feb 17, 2017

Oops, just realized this is missing one more clean-up...

@ttuegel
Copy link
Member Author

ttuegel commented Feb 17, 2017

...and there we go!

I can't even follow my own instructions. 😺

@vandenoever
Copy link
Contributor

Looks good. Glad that the KDE update process is becoming even smoother.

@ttuegel
Copy link
Member Author

ttuegel commented Feb 18, 2017

The Travis failure is spurious: it tries to build clang, which was updated in master. 🙄

@ttuegel ttuegel merged commit a8b4980 into NixOS:master Feb 18, 2017
@ttuegel ttuegel deleted the kde5-instructions branch February 18, 2017 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants