Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: 1.15 -> 1.15.1 #22907

Merged
merged 1 commit into from Feb 19, 2017
Merged

rustc: 1.15 -> 1.15.1 #22907

merged 1 commit into from Feb 19, 2017

Conversation

wizeman
Copy link
Member

@wizeman wizeman commented Feb 17, 2017

Motivation for this change

Minor bug fix update, fixes a soundness bug and a security regression.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@wizeman, thanks for your PR! By analyzing the history of the files in this pull request, we identified @the-kenny, @dvc94ch and @retrry to be potential reviewers.

LnL7
LnL7 reviewed Feb 17, 2017
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust and cargo look good but ripgrep fails to build on nixos

@LnL7
Copy link
Member

LnL7 commented Feb 17, 2017 

test unrestricted2 ... ok
test with_filename ... ok
test with_heading ... ok
test word ... ok
test with_heading_default ... ok

failures:

---- regression_210 stdout ----
	thread 'regression_210' panicked at '/tmp/nix-build-ripgrep-0.4.0.drv-0/ripgrep-0.4.0-src/target/debug/deps/ripgrep-tests/regression_210/72/foo�bar: Error { repr: Os { code: 84, message: "Invalid or incomplete multibyte or wide character" } }', tests/workdir.rs:261
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    regression_210

test result: FAILED. 105 passed; 1 failed; 0 ignored; 0 measured

error: test failed
builder for ‘/nix/store/znqd0qdndm29nsl2j7h8v5mcjnzw687j-ripgrep-0.4.0.drv’ failed with exit code 101

@grahamc
Copy link
Member

grahamc commented Feb 18, 2017

@LnL7 was this on darwin? or linux?

@LnL7
Copy link
Member

LnL7 commented Feb 18, 2017

Only on linux for once, the darwin build was green.

@retrry
Copy link
Contributor

retrry commented Feb 18, 2017

If this will not be merged I will test it on monday.

@grahamc
Copy link
Member

grahamc commented Feb 18, 2017

Can you try again, @LnL7? I can't reproduce, and burntsushi can't imagine why it failed.

@LnL7
Copy link
Member

LnL7 commented Feb 18, 2017

Sure, might also just be an issue specific to ripgrep it's just the first rust package I thought of.

@LnL7
Copy link
Member

LnL7 commented Feb 19, 2017

Same issue, but it also fails on the current master with --check so It's unrelated.

@LnL7 LnL7 merged commit 16fd03d into NixOS:master Feb 19, 2017
@wizeman wizeman deleted the u/upd-rust branch February 22, 2017 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: rust 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wizeman @mention-bot @LnL7 @grahamc @retrry