Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos.openntpd: don't spam systemd journal #22903

Merged
merged 1 commit into from Feb 20, 2017

Conversation

wizeman
Copy link
Member

@wizeman wizeman commented Feb 17, 2017

Motivation for this change

Starting ntpd with the -d option spams the systemd journal.
Instead, let the server fork.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Starting `ntpd` with the `-d` option spams the systemd journal.
Instead, let the server fork.
@mention-bot
Copy link

@wizeman, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aszlig, @wkennington and @robberer to be potential reviewers.

@globin
Copy link
Member

globin commented Feb 20, 2017

👎 I don't like this I think all logs should go to the journal.

@wizeman
Copy link
Member Author

wizeman commented Feb 20, 2017

@globin: The log still goes to the journal. Systemd intercepts syslog messages.

@globin
Copy link
Member

globin commented Feb 20, 2017

Then I don't understand what this changes?

@wizeman
Copy link
Member Author

wizeman commented Feb 20, 2017

To be more clear, this PR is preventing openntpd from outputting messages every few minutes, each time it receives a response from an NTP server. This seems useful for debugging purposes, but that's not what we normally want.

Instead, it tells openntpd to start in the traditional server mode of operation (using a forking model), which makes openntpd only output log messages for important events.

@wizeman
Copy link
Member Author

wizeman commented Feb 20, 2017

@globin: sorry I wasn't more clear before!

@globin globin merged commit d9ae886 into NixOS:master Feb 20, 2017
@wizeman wizeman deleted the u/fix-openntpd-spam branch April 19, 2017 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants