Update CONTRIBUTING.rst, add issue and PR templates #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Kwpolska
commented
Feb 17, 2017
Kwpolska
commented
- Minor copyediting and content updates for CONTRIBUTING.rst.
- Issue template which asks for environment information.
- PR template which tells people about CONTRIBUTING.rst and what they need to do
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
| ``git pull``, please run ``git config pull.rebase true`` to prevent merges | ||
| from happening and replace them with rebase goodness. There is also an | ||
| “emergency switch” in case rebases fail and you do not know what to do: | ||
| ``git pull --no-rebase``. |
There was a problem hiding this comment.
Why did you remove this part about rebasing? I've always used Nikola's CONTRIBUTING.rst file to look this up when I forgot how to change the pull.rebase settings, so I will definitely miss this part ;-)
There was a problem hiding this comment.
added back and reworded.
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.