Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stanchion: remove ssl option #22898

Merged
merged 1 commit into from Feb 17, 2017
Merged

stanchion: remove ssl option #22898

merged 1 commit into from Feb 17, 2017

Conversation

mdaiter
Copy link
Contributor

@mdaiter mdaiter commented Feb 17, 2017 •
edited

Motivation for this change

stanchion_ssl no longer is an available option within stanchion's configuration file. Therefore, we should remove this, as it prevents the launch of stanchion

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@makefu
Copy link
Contributor

makefu commented Feb 17, 2017

lgtm
for reference: http://docs.basho.com/riak/cs/2.1.1/cookbooks/configuration/riak-cs/#enabling-ssl

@globin globin merged commit 336d6cc into NixOS:master Feb 17, 2017
@mdaiter mdaiter deleted the stanchionSslFix branch February 17, 2017 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdaiter @makefu @globin