Libretto theme #97
Merged
Libretto theme #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a new theme for Nikola. Hope this gets accepted. :)
Kwpolska
reviewed
Feb 17, 2017
| supported with this theme, | ||
|
|
||
| * 3rd-party comment system (is it even possible to do this without JS ?) | ||
| * Tags |
There was a problem hiding this comment.
The original theme didn't have any UI for it. I didn't want to 'improvise' too much. Already did that for the archives part.
| @@ -0,0 +1,28 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
No need to duplicate this file.
There was a problem hiding this comment.
I'm not inheriting from base for this theme. It's a 'from scratch' implementation. On my browser at least, things work better with this file included.
|
The theme looks pretty good, but tags are pretty important. Could you please work on making them work? Leaving the built-in template from base would work better than an empty page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new theme for Nikola. Hope this gets accepted. :)