Changed oblong NTPH hole to Edge.Cuts #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the board to be manufactured with OSH park, that does not accept oblong NPTH holes, the cutout for the strap has been changed to an inside cutout, which should work with all the common manufacturers.
|
@flummer Thanks for this fix. I work for OSH Park and have just ordered your version on our 0.8mm thickness 2 layer service. I should have it by end of this month and will try to assemble with a stencil and paste. |
|
I'm going to merge this change. Will need to generate new gerber files and test with different manufacturers again. |
|
@flummer if you email me your shipping address, then I'll put in an order for you too: drew@oshpark.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the board to be manufactured with OSH park, that does not accept oblong NPTH holes, the cutout for the strap has been changed to an inside cutout, which should work with all the common manufacturers.
Relates to Issue #12