microsoft_gsl: init at 2017-02-13 #22852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This derivation executes the libraries unit tests. Is that the correct choice? |
grahamc
reviewed
Feb 16, 2017
| src = fetchgit { | ||
| url = "https://github.com/Microsoft/GSL.git"; | ||
| rev = "3819df6e378ffccf0e29465afe99c3b324c2aa70"; | ||
| sha256 = "03d17mnx6n175aakin313308q14wzvaa9pd0m1yfk6ckhha4qf35"; |
There was a problem hiding this comment.
This would be better implemented with fetchFromGitHub:
fetchFromGitHub {
owner = "Microsoft";
repo = "GSL";
rev = "3819df6e378ffccf0e29465afe99c3b324c2aa70";
sha256 = "..."; # this will be different then the sha you already have
}There was a problem hiding this comment.
I used fetchgit instead of fetchFromGithub as I need the submodules to be checked out in order to run the test suite.
|
Running unit tests is always good and using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
add the GSL lib from microsoft
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)