findutils: plug memory hole in find #22857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was the patch also reported upstream? https://www.gnu.org/software/findutils/ |
Not by me. |
|
The Ubuntu bug shows no indication of that. |
|
I reported it to the findutils tracker: https://savannah.gnu.org/bugs/index.php?50326 |
vcunat
added a commit
that referenced
this pull request
Feb 16, 2017
Using the upstream patch directly. It's copied in nixpkgs, because: - fetchpatch isn't usable at this point in bootstrapping, - the upstream patch creates collisions in NEWS.
|
Upstream now pushed a different but functionally equivalent fix, so I took that "wording" instead. Thanks for getting this moving! valgrind still shows some leaks for me, but they seem small now (hopefully constant amount), and no bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Running
update-locatedb.servicehas been reproducibly making my computer unusable for some time now, with thefindutility using memory north of 12G (RES) and growing. Thankfully, someone over at the ubuntu bug tracker has already developed a fix for this memory hole and I can confirm that with itupdate-locatedbnow smoothly runs in the background, with find taking no more than a couple of megs, as it should be.I'm now running this patch as part of my
services.locate.locatefindutils, though this PR applies it to the findutils in all-packages.nix and will result in a mass-rebuild.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)