gpgme: fix build on macOS #22848
Merged
gpgme: fix build on macOS #22848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@loskutov can you also test with |
|
@davidak it seems to be broken on macOS :/ |
|
@loskutov also with other packages? |
|
@LnL7 could you take a look too? |
LnL7
approved these changes
Feb 25, 2017
| @@ -30,6 +30,9 @@ stdenv.mkDerivation rec { | |||
| NIX_CFLAGS_COMPILE = | |||
| with stdenv; lib.optional (system == "i686-linux") "-D_FILE_OFFSET_BITS=64"; | |||
|
|
|||
| AM_CXXFLAGS = | |||
| with stdenv; lib.optional (isDarwin) "-D_POSIX_C_SOURCE=200809L"; | |||
There was a problem hiding this comment.
Does this have to be conditional or will this get propagated to dependencies? The with is also a bit overkill IMHO.
There was a problem hiding this comment.
with usage follows the pattern of the previous line; as for being conditional, I’m not sure: on one hand, it looks like strdup is only specified to be defined if one of the several macros is defined; on the other hand—it used to work, so why fix what’s not broken on other platforms?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix build on macOS (it complained on
strdupbeing undefined)Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)