Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdf2htmlEX: init at 0.14.6 #22480

Merged
merged 1 commit into from Feb 10, 2017
Merged

pdf2htmlEX: init at 0.14.6 #22480

merged 1 commit into from Feb 10, 2017

Conversation

taktoa
Copy link
Member

@taktoa taktoa commented Feb 6, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

src = fetchFromGitHub {
repo = "pdf2htmlEX";
owner = "coolwanglu";
rev = "a296d3babc529ca2165fe267dd29ec67a2af8aae";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider rev = v0.14.6 instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@joachifm joachifm merged commit 176a967 into NixOS:master Feb 10, 2017
@taktoa taktoa deleted the pdf2htmlEX branch September 18, 2017 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants