-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ycmd: 2016-01-12 -> 2017-02-03 #22490
Conversation
@cstrahan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh, @rasendubi and @dezgeg to be potential reviewers. |
With the code as it is right now, I inject the following into import os; os.environ['PATH'] = ('{0}:{1}' if os.getenv('PATH', '') != '' else '{1}').format('$program_PATH', os.getenv('PATH', '')) ... where That preserves the behavior of the wrapper script, but I don't know if it's really necessary. In fact, that puts the build-time So, I think I'm not going to try to preserve the |
Also TODO in a separate PR: have the vim plugin use this package, instead of it also compiling ycmd. |
Also, remove wrapper bash script and symlink completion backends to ycmd can find them.
34cffd6
to
fb70fb5
Compare
YouCompleteMe needs the packages to be available in ycmd's third_party directory, and things start getting pretty complicated when we try to use our package libs instead of the vendored ones. We can revisit this at a later time, but we'll need to ensure that we don't break the vim plugin. Tested in vim.
In the latest commit I've switched to using the vendored python libs - YouCompleteMe expects that it can source those libs, and things get very tricky when trying to use our packaged libraries while trying not to break YCM's assumptions. We could probably patch YCM's source, but by using the vendored python libs, we make our packaged YouCompleteMe and ycmd work seamlessly together (see #22614 for the changes to the vim plugin). |
This does seem to break darwin build: https://hydra.nixos.org/build/48027016 |
Also, remove wrapper bash script and symlink completion backends to ycmd can find them.
This builds on #22463 and should fix #14349.