Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdiff3-qt5: init at 1.7.0 #22477

Merged
merged 1 commit into from Feb 6, 2017
Merged

kdiff3-qt5: init at 1.7.0 #22477

merged 1 commit into from Feb 6, 2017

Conversation

peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Feb 6, 2017

Motivation for this change

Upstream hasn't made a formal release yet of the qt5 version which is why I'm
not replacing the existing kde4 version. The 1.7.0 tag is the most recently released version that then carries a number of patches to work with qt5. Upstream has told me that a formal release will be coming "soon".

Cc: @ttuegel

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Upstream hasn't made a formal release yet of the qt5 version which is why I'm
not replacing the existing kde4 version.
@ttuegel ttuegel merged commit f0bbf73 into NixOS:master Feb 6, 2017
@peterhoeg peterhoeg deleted the f/kdiff3 branch February 7, 2017 01:07
@peterhoeg peterhoeg restored the f/kdiff3 branch February 7, 2017 06:17
@peterhoeg peterhoeg deleted the f/kdiff3 branch March 1, 2017 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants