nixos: allow supply customized locale package #22489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overriding ``glibcLocales`` via nixpkgs.overlays not works, so I added i18n.glibcLocales parameter, defaulted with old override, using i18n.supportedLocales.
|
@avnik, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MarcWeber, @edolstra and @abbradar to be potential reviewers. |
|
What's the concrete use case here? What else would one want to override? |
|
My use case -- https://github.com/avnik/nixos-configs/blob/master/common/i18n.nix#L58 (ancient application in wine, which require ru_RU.CP1251 locale, so I build locales with patches from debian). I not submit this code as well, because not all locales built this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding
glibcLocalesvia nixpkgs.overlays not works,so I added i18n.glibcLocales parameter, defaulted with
old override, using i18n.supportedLocales.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)