New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export haskellSrc2nix, hackage2nix. Prefer local builds. Name arg optional. #22471
Conversation
I am not fond of the notion of exporting I guess we can expose those functions now and just break backwards-compatibility in the future if we want to. There's probably only a handful of people in the world who care about them, so it's not that big a deal. If we do, then we should definitely choose better names though. |
@peti good points, and I agree that there are some naming issues, and we should definitely avoid name collisions. I think these functions are useful, though. I've used variants of the one currently called I can take a stab at those changes, if you care to share your concerns with me. |
Yes, I like those names much better than the ones we currently have. I'd be fine with exporting those. |
The most important improvement is that I want to get rid of the dependency on the Another issue is that the |
I like all your proposed changes. Go for it. |
Any update on this pull request? |
Closing due to lack of activity, feel free to reopen this if needed. |
Motivation for this change
See issue #22427 and #22469
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)cc @peti @3noch