New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chromium: 55.0.2883.87 -> 56.0.2924.87 [nixos-stable] #22484
Conversation
Thank you! Missed this before :/ |
Looks like that's making the chromium test fail and holding release-16.09… http://hydra.nixos.org/build/47936140/nixlog/1 |
Restarting the failing test seems to have fixed it. Thanks for the heads up! |
Ugh, or not. I thought it had. |
Are there security updates in this patch that are serious enough that we shouldn't revert it? |
I just checked the master log for intermittent commits, that I might have missed. There don't seem to be for chromium. Has something changed in the test suite, that we need to pull in? The latest hydra build seems to have been deleted from the binary cache. I suppose that's because the it was manually restarted? http://hydra.nixos.org/build/47936180
Definitely! https://chromereleases.googleblog.com/2017/01/stable-channel-update-for-desktop.html |
There is a commit to the testsuite, that has not yet been applied to stable: cd10e3c I pushed it to the stable branch, that this PR has been created from |
Nice find, confirmed that it fixed the problem & pushed. |
(in e76c8ac) |
stable update, security fixes