Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: 55.0.2883.87 -> 56.0.2924.87 [nixos-stable] #22484

Merged
merged 1 commit into from Feb 8, 2017

Conversation

bendlas
Copy link
Contributor

@bendlas bendlas commented Feb 6, 2017

stable update, security fixes

@mention-bot
Copy link

@bendlas, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aszlig to be a potential reviewer.

@grahamc grahamc merged commit 4f876a4 into NixOS:release-16.09 Feb 8, 2017
@grahamc
Copy link
Member

grahamc commented Feb 8, 2017

Thank you! Missed this before :/

@obadz
Copy link
Contributor

obadz commented Feb 11, 2017

Looks like that's making the chromium test fail and holding release-16.09… http://hydra.nixos.org/build/47936140/nixlog/1

@grahamc
Copy link
Member

grahamc commented Feb 11, 2017

Restarting the failing test seems to have fixed it. Thanks for the heads up!

@grahamc
Copy link
Member

grahamc commented Feb 11, 2017

Ugh, or not. I thought it had.

@obadz
Copy link
Contributor

obadz commented Feb 11, 2017

Are there security updates in this patch that are serious enough that we shouldn't revert it?

@bendlas
Copy link
Contributor Author

bendlas commented Feb 11, 2017

I just checked the master log for intermittent commits, that I might have missed. There don't seem to be for chromium. Has something changed in the test suite, that we need to pull in?

The latest hydra build seems to have been deleted from the binary cache. I suppose that's because the it was manually restarted? http://hydra.nixos.org/build/47936180

Are there security updates in this patch that are serious enough that we shouldn't revert it?

Definitely! https://chromereleases.googleblog.com/2017/01/stable-channel-update-for-desktop.html

@bendlas
Copy link
Contributor Author

bendlas commented Feb 11, 2017

There is a commit to the testsuite, that has not yet been applied to stable: cd10e3c

I pushed it to the stable branch, that this PR has been created from

@grahamc
Copy link
Member

grahamc commented Feb 11, 2017

👍 ⚡️ nice work, @bendlas, thank you! /cc @aszlig

@obadz
Copy link
Contributor

obadz commented Feb 11, 2017

Nice find, confirmed that it fixed the problem & pushed.

@obadz
Copy link
Contributor

obadz commented Feb 12, 2017

(in e76c8ac)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants