Fix validity checks in ui_ask_singlechoice

Check that input is an integer before doing a comparison with it, and check that it is positive. Backport of 01a507a.
macports · Feb 16, 2017 · e214c74 · e214c74
1 parent b2ec8c8
commit e214c74
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/port/port.tcl b/src/port/port.tcl
@@ -5480,7 +5480,7 @@ namespace eval portclient::questions {
                 throw
             }
             signal -restart error {TERM INT}
-            if {($input <= [llength $ports] && [string is integer -strict $input])} {
+            if {[string is integer -strict $input] && $input <= [llength $ports] && $input > 0} {
                 return [expr {$input - 1}]
             } else {
                 puts "Please enter an index from the above list."