awesome-4.0: Add optional hicolor-icon-theme for theme support #22888
Conversation
|
@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @lethalman and @lovek323 to be potential reviewers. |
|
Contacted previous maintainer and he replied that he no longer uses Linux so possibly I may take this package up? |
|
You can certainly add yourself to |
|
@vcunat Added myself to maintainers, so I am done editing as long as it looks good to you :) |
| @@ -4,11 +4,17 @@ | |||
| , compton, procps, iproute, coreutils, curl, alsaUtils, findutils, xterm | |||
| , which, dbus, nettools, git, asciidoc, doxygen | |||
| , xmlto, docbook_xml_dtd_45, docbook_xsl, findXMLCatalogs | |||
| , libxkbcommon, xcbutilxrm | |||
| , libxkbcommon, xcbutilxrm, lib, pkgs, | |||
There was a problem hiding this comment.
Please import hicolor_icon_theme directly rather then use pkgs here. Also we usually access lib by using stdenv.lib.
There was a problem hiding this comment.
@Mic92 I believe I changed it to what I believe you mean ?
| let | ||
| version = "4.0"; | ||
| available = x: x != null; |
There was a problem hiding this comment.
I have no idea, I didn't put it there, I barely changed the nix file :)
There was a problem hiding this comment.
The diff indicated the change was yours, but never mind - now it's gone.
There was a problem hiding this comment.
@vcunat that is weird, but your right seems I did, but don't remember doing it lol;
| let | ||
| version = "4.0"; | ||
| in with luaPackages; | ||
| assert enableHicolorTheme -> hicolor_icon_theme !=null; |
There was a problem hiding this comment.
You don't actually use hicolor_icon_theme anywhere (or I'm just very sleepy but browser search seems to agree with me).
There was a problem hiding this comment.
@abbradar I think I did what you wanted me to do, by adding it through ++ optional
|
It's strange that it helped you before, and not sure adding the theme to inputs will actually help -- depends on how awesome finds the theme. Have you tested it in a VM? It may work on your host machine because `hicolor_icon_theme` is already pulled by something into the system environment. To test in a VM write a very minimal NixOS configuration which uses awesome and run:
… NIXOS_CONFIG=$PWD/test-config.nix nixos-rebuild build-vm
On February 17, 2017 8:14:01 PM GMT+03:00, ndowens ***@***.***> wrote:
ndowens commented on this pull request.
> }:
-let
- version = "4.0";
-in with luaPackages;
+assert enableHicolorTheme -> hicolor_icon_theme !=null;
@abbradar I think I did what you wanted me to do, by adding it through
++ optional
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#22888 (comment)
--
Nikolay.
|
|
@abbradar i had to add it to my environment.systemPackages for it to work; didn't add it to package, though I am trying to test it in VM, but the store is not writeable in build-vm so I am not having success and can't find a setting to enable writablestore |
|
Maybe we should just add |
|
@abbradar maybe so, in case people expect 4.0 themes to work automaticly |
|
I think installing a default icon theme is okay by default -- you usually need it anyway. BTW you don't need |
|
@abbradar So put it in propagated? the hicolor_icon_theme is what solved my issue with using 4.0 themes |
|
Yep, it should be okay. |
Awesome 4.0: Edited meta information Awesome-4.0: removed pkgs and used hicolor directly modified: pkgs/applications/window-managers/awesome/default.nix Awesome-4.0: Removed let:in modified: pkgs/applications/window-managers/awesome/default.nix Awesome-4.0: Added hicolor_icon_theme to optional buildInputs modified: pkgs/applications/window-managers/awesome/default.nix Awesome-4.0: removed optional and added propagatedUserEnvPkgs modified: pkgs/applications/window-managers/awesome/default.nix
|
@abbradar changed, maybe this will work |
|
Should be okay now! Pushed to master, thank you for the fix. |
Motivation for this change
Add hicolor_icon_theme optional dependency, so 4.0 themes such as https://github.com/copycat-killer/awesome-copycats will work
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)