Skip to content

Commit

Permalink
Fix 'port lint' for multi-valued maintainers
Browse files Browse the repository at this point in the history
(cherry picked from commit 2cadd1b)
  • Loading branch information
jmroot committed Feb 17, 2017
1 parent 435dae3 commit 98d55a8
Showing 1 changed file with 16 additions and 14 deletions.
30 changes: 16 additions & 14 deletions src/port1.0/portlint.tcl
Expand Up @@ -591,20 +591,22 @@ proc portlint::lint_main {args} {
incr errors
}

foreach addr $maintainers {
if {$addr eq "nomaintainer@macports.org" ||
$addr eq "openmaintainer@macports.org"} {
ui_warn "Using full email address for no/open maintainer"
incr warnings
} elseif {[regexp "^(.+)@macports.org$" $addr -> localpart]} {
ui_warn "Maintainer email address for $localpart includes @macports.org"
incr warnings
} elseif {$addr eq "darwinports@opendarwin.org"} {
ui_warn "Using legacy email address for no/open maintainer"
incr warnings
} elseif {[regexp "^(.+)@(.+)$" $addr -> localpart domain]} {
ui_warn "Maintainer email address should be obfuscated as $domain:$localpart"
incr warnings
foreach maintainer $maintainers {
foreach addr $maintainer {
if {$addr eq "nomaintainer@macports.org" ||
$addr eq "openmaintainer@macports.org"} {
ui_warn "Using full email address for no/open maintainer"
incr warnings
} elseif {[regexp "^(.+)@macports.org$" $addr -> localpart]} {
ui_warn "Maintainer email address for $localpart includes @macports.org"
incr warnings
} elseif {$addr eq "darwinports@opendarwin.org"} {
ui_warn "Using legacy email address for no/open maintainer"
incr warnings
} elseif {[regexp "^(.+)@(.+)$" $addr -> localpart domain]} {
ui_warn "Maintainer email address should be obfuscated as $domain:$localpart"
incr warnings
}
}
}

Expand Down

0 comments on commit 98d55a8

Please sign in to comment.