gnupg21: Fix scdaemon for usb smartcards #22891
Conversation
|
@danielfullmer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @oxij and @kirelagin to be potential reviewers. |
|
@danielfullmer Do you know if these patches have any impact on the problem discussed in issue #20484 ? We, OSX users, have currently imho no clue why scdaemon crashes and suspect the error in OSX impure header incomatibilities. Any clue? |
|
@periklis This is a guess on my part, but I would expect not. The included patches fix a regression introduced by 2.1.18, and since OSX users have had this problem with previous versions, I would be surprised if this fixed things for them. Still, it seems worthwhile for someone to test this on OSX. |
|
I confirm, this makes my YubiKey at least visible to scdaemon (I can’t test it with complete gnupg right now as I’m on mac, but I’m working on it).
I’m not sure what you mean, maybe you were thinking about some other issue, but the one you referred to is well-known, and the comments explain pretty clearly what is the cause and how to work it around. Of course, it is in no way related to gnupg itself. |
|
Yes, everything works. I managed to generate a set of keys on the YubiKey and then use it to decrypt a file. I guess, this sould be merged as soon as possible. |
pkgs/tools/security/gnupg/21.nix
Outdated
| ./fix-libusb-include-path.patch | ||
| # TODO: Remove the following patches on the next gnupg release after 2.1.18 | ||
| ./0028-scd-Backport-two-fixes-from-master.patch | ||
| ./0029-scd-Fix-use-case-of-PC-SC.patch |
There was a problem hiding this comment.
Can we maybe fetch these patches from gnupg's version control system instead of adding them to nixpkgs?
There was a problem hiding this comment.
@fpletz While I can find the "Fix-use-case-of-PC-SC" commit in the gnupg repo, I can't find the "Backport two fixes from master" patch in the gnupg repo---probably because the changes in that patch were spread across other commits in master. I've opted to fetch these patches from a debian source. Let me know if you'd prefer something else.
The use of smartcard functionality for yubikeys (and presumably other usb smartcards) was broken in gnupg 2.1.18. This has apparently already been fixed in gnupg master, and debian backports the included patches for 2.1.18. See also: https://bugs.gnupg.org/gnupg/issue2933 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=852702 NixOS#21991
danielfullmer
force-pushed
the
gnupg-scdaemon-fix
branch
from
a019248
to
d0da729
Compare
|
@kirelagin I meant only the issue #20484. However, i check it again right now and read the updates. Thx for the notice, i am still using the DYLD_FRAMEWORK_PATH workaround. |
The use of smartcard functionality for yubikeys (and presumably other
usb smartcards) was broken in gnupg 2.1.18. This has apparently already been
fixed in gnupg master, and debian backports the included patches for 2.1.18.
See also:
https://bugs.gnupg.org/gnupg/issue2933
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=852702
#21991
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)