Fix another small bug where listen_type was not being detected. #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON data contained strings while the variables LISTEN_TYPE_SINGLE etc are integers, so we need to use _get_listen_type to make sure that the code works properly. Without this, payloads with listen_type 'single' but more than one listens were being accepted.
paramsingh
force-pushed
the
listen-type-fix
branch
from
9c64180
to
edc1810
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON data contained strings while the variables LISTEN_TYPE_SINGLE
etc are integers, so we need to use _get_listen_type to make sure
that the code works properly. Without this, payloads with listen_type
'single' but more than one listens were being accepted.