dateutils: init at 0.4.1 #22512
dateutils: init at 0.4.1 #22512
Conversation
| { stdenv, fetchurl }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| version = "0.4.1"; |
There was a problem hiding this comment.
please fix indentation in this file
There was a problem hiding this comment.
I hope I've done that correctly, thanks.
There was a problem hiding this comment.
two spaces are needed. Here it's correct.
| version = "0.4.1"; | ||
| name = "dateutils-${version}"; | ||
|
|
||
| src =fetchurl { |
There was a problem hiding this comment.
I think you're supposed to use fetchFromBitbucket
There was a problem hiding this comment.
Is this the preference? It can't find the make file correctly when I use the fetchFromBitbucket.
| homepage = http://www.fresse.org/dateutils/; | ||
| license = licenses.bsd3; | ||
| platforms = platforms.linux; | ||
| maintainers = [ maintainers.paperdigits ]; |
There was a problem hiding this comment.
did you add yourself to lib/maintainers.nix?
| }; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Virtual lighttable and darkroom for photographers"; |
There was a problem hiding this comment.
Please also fix the description, and any other metadata that may have been copypasted
There was a problem hiding this comment.
I've done that, thanks.
paperdigits
force-pushed
the
dateutils
branch
from
8e66607
to
720efc1
Compare
lib/maintainers.nix
Outdated
| @@ -358,6 +358,7 @@ | |||
| paholg = "Paho Lurie-Gregg <paho@paholg.com>"; | |||
| pakhfn = "Fedor Pakhomov <pakhfn@gmail.com>"; | |||
| palo = "Ingolf Wanger <palipalo9@googlemail.com>"; | |||
| paperdigits = "Mica Semrick <mica@silentumbrella.com>"; | |||
| name = "dateutils-${version}"; | ||
|
|
||
| src =fetchurl { | ||
| url = "https://bitbucket.org/hroptatyr/dateutils/downloads/${name}.tar.xz"; |
paperdigits
force-pushed
the
dateutils
branch
from
720efc1
to
70a7fe9
Compare
|
Thanks for your patients, I've attempted to correct the cited problems. |
Motivation for this change
Package a nice CLI app for computing dates. Particularly useful for finding relative dates.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)