Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vapoursynth: disable OCR by default #22943

Merged
merged 1 commit into from
Feb 19, 2017
Merged

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 18, 2017

Motivation for this change

Vapoursynth uses tesseract for the ocr.Recognize() function.
By disabling the OCR support the closure size of vapoursynth gets reduced by 1.2GB, so building mpv with vapoursynth enabled now increase the size by "only" 92MB.

Things done
  • Tested using sandboxing
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

To be clear, ocr.Recognize is not "core functionality" that users of vapoursynth would normally expect to have?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 19, 2017

Vapoursynth it's a tool for video manipulation and post-production. The OCR function it's definitely not a main feature and has a very specific use case (it works on text-only frames); so I think the priority here is space-saving. Also, not really a valid reason, but I added this package because I needed to run scripts in mpv and I might be the only one using it.

@joachifm joachifm merged commit 1ae9b50 into NixOS:master Feb 19, 2017
@rnhmjoj rnhmjoj deleted the vapour-ocr branch September 12, 2017 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants