Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marathon: 1.3.6 -> 1.4.1 #22935

Merged
merged 1 commit into from
Feb 21, 2017
Merged

marathon: 1.3.6 -> 1.4.1 #22935

merged 1 commit into from
Feb 21, 2017

Conversation

pradeepchhetri
Copy link
Contributor

@pradeepchhetri pradeepchhetri commented Feb 18, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@pradeepchhetri, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rushmorem, @kamilchm and @pSub to be potential reviewers.

@pSub
Copy link
Member

pSub commented Feb 18, 2017

It seems some tests are failing on travis.

@pradeepchhetri
Copy link
Contributor Author

I am having a look at it. Thanks.

@rycee
Copy link
Member

rycee commented Feb 19, 2017

This seems like a more general error with building the Python bindings for Protobuf 2.6. So no program depending on this version will build OK. For example nix-build -A pythonPackages.ddar will result in the same error as shown in travis.

Unfortunately current Mesos doesn't work with newer protobuf versions, apparently it will in an upcoming release (maybe 1.3.0?), see MESOS-5186 and MESOS-6138.

@rycee
Copy link
Member

rycee commented Feb 19, 2017

I tried applying #22061 and then build this. That worked quite well both Mesos and Marathon built successfully.

@pradeepchhetri
Copy link
Contributor Author

So I guess we can merge this once #22061 gets merged into master ?

@rycee
Copy link
Member

rycee commented Feb 19, 2017

Yeah, I would be in favor of that.

@rycee rycee modified the milestone: 17.03 Feb 19, 2017
@kamilchm
Copy link
Member

https://github.com/mesosphere/marathon/releases/tag/v1.4.1

@jyp jyp mentioned this pull request Feb 20, 2017
Merged
7 tasks
@grahamc
Copy link
Member

grahamc commented Feb 21, 2017

That PR has been merged. @rycee can you take another look?

@pradeepchhetri
wq
ecca0c9 
marathon: 1.3.6 -> 1.4.1
@pradeepchhetri pradeepchhetri changed the title marathon: 1.3.6 -> 1.4.0 marathon: 1.3.6 -> 1.4.1 Feb 21, 2017
@fpletz fpletz merged commit be30dce into NixOS:master Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pradeepchhetri @mention-bot @pSub @rycee @kamilchm @grahamc @fpletz