tox clients and libraries updates #22775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterhoeg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @viric, @akaWolf and @obadz to be potential reviewers. |
|
Regarding the naming of the libraries, the only user of "libtoxcore-dev" is "tox-prpl" which while not having any immediate plans to move to the proper libtoxcore, the main dev agrees that it is the way forward. As a consequence, when that happens we will be left with "libtoxcore-old" and "libtoxcore" which seems reasonable. |
|
cc maintainer @jgeerds |
|
@peterhoeg thank you very much for your effort! I know, versioning in libtoxcore is a pain... I did a quick check with toxic/ratox/utox and it seems to work. I guess its save to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As I'm sick and tired of skype, I needed qtox to work properly.
As a young project there's been quite a bit of churn and it turns out a number of changes have been made to the libraries.
We currently have 3 versions of libtoxcore:
All the tox clients have now been updated and those that can use the proper libtoxcore do (spoiler, we only have one user each of -old and -new).
All this came about because I wanted the latest qtox... Oh well.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Cc: @grahamc @globin