MBS-9219: Fix editing known languages field in user profile form #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 19, 2017 20:23
In user profile editing form, template for adding a known language caused to systematically save an unwanted `[Multiple languages]` additional entry. This is solved by moving the template out of the <form> element.
Properly number and replace `id` and `name` template properties for added known languages in user profile editing form.
mwiencek
reviewed
Feb 20, 2017
root/account/edit.tt
Outdated
| [% r.select(extra_field.field('language_id'), id => 'fluency-template', class => 'language_id',) %] | ||
| [% r.select(extra_field.field('fluency'), class => 'fluency') %] | ||
| [% r.select(extra_field.field('language_id'), id => 'id-language-id-template', class => 'language_id', name => 'language-id-template') %] | ||
| [% r.select(extra_field.field('fluency'), id => 'id-fluency-template', class => 'fluency', name => 'fluency-template') %] |
There was a problem hiding this comment.
Something I'm wondering is, are these id and name attributes actually needed? It seems they aren't used anywhere and are just overridden in the script below, so we can just remove them.
There was a problem hiding this comment.
Indeed ids are of no use. They had to be unique, hence the override, but removal is even better. Only names are needed for form submission. And yes, template’s name is worthless. Cleaned up in 547b27e
mwiencek
approved these changes
Feb 20, 2017
- Remove unused `id` and `name` attributes from template `<select>` - Set `name` attribute only to added language input
|
Cleaned up in 547b27e (to be squashed with previous commit) |
mwiencek
approved these changes
Feb 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug MBS-9219:[Multiple languages] (Basic) is automatically added when editing/saving an editor profile and clean template code up a bit.