PyZufall: init at 0.13.2 #22981
PyZufall: init at 0.13.2 #22981
Conversation
| sha256 = "1jffhi20m82fdf78bjhncbdxkfzcskrlipxlrqq9741xdvrn14b5"; | ||
| }; | ||
|
|
||
| # Cannot build wheel otherwise (zip 1980 issue) |
There was a problem hiding this comment.
Odd, this is the second PR this week where someone had to do this.
| }; | ||
|
|
||
| # Cannot build wheel otherwise (zip 1980 issue) | ||
| SOURCE_DATE_EPOCH=315532800; |
There was a problem hiding this comment.
I just tested and didn't need this, so please remov
There was a problem hiding this comment.
i looked how other python packages have done it and just transfered it since it looked like a general issue. thanks for testing and the feedback!
|
|
||
| # disable tests due to problem with nose | ||
| # https://github.com/nose-devs/nose/issues/1037 | ||
| doCheck = false; |
There was a problem hiding this comment.
the archive does not contain any tests, so that's why it fails
There was a problem hiding this comment.
it had doctests in the code and test.py, which is not included in the archive in the current release, but everytime the tests fail even before the first test is executed (see linked issue)
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = "https://pyzufall.readthedocs.io/de/latest/"; | ||
| description = "Library zum Erzeugen von zufälligen Daten"; |
|
@FRidh is the latest commit good? do you have a solution for the problem with tests runing with Nix? It don't appear local or with Travis. |
There was a problem hiding this comment.
@FRidh is the latest commit good?
Looks good, just one more small edit.
do you have a solution for the problem with tests runing with Nix? It don't appear local or with Travis.
If tests aren't included there's not much that can be done. Sometimes we then fetch from the repository instead of PyPI. This you could do but that I leave up to you as maintainer.
| homepage = "https://pyzufall.readthedocs.io/de/latest/"; | ||
| description = "Library for generating random data and sentences in german language"; | ||
| license = licenses.gpl3Plus; | ||
| platforms = platforms.all; |
There was a problem hiding this comment.
platforms should be removed because its inherited from the Python interpreter.
There was a problem hiding this comment.
ok, i deleted it and tested build again.
|
@FRidh the file that is missing in the archive contains 4 more tests, about 48 are in the code as doctests. the error happens before the first test is executed. i have also testet it with the repo. |
|
also done a rebase again to fix merge conflicts. |
Motivation for this change
I want to use it on a server running NixOS and maybe it's useful for more Nix users :)
The
descriptionis in german since the library outputs random german words and sentences.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)