Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geogebra: 5-0-328-0 -> 5-0-331-0 #22993

Merged
merged 2 commits into from
Feb 19, 2017
Merged

geogebra: 5-0-328-0 -> 5-0-331-0 #22993

merged 2 commits into from
Feb 19, 2017

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Feb 19, 2017

Motivation for this change

GeoGebra needs an update (again) to prevent any failing builds when 5-0-328-0 is removed from the download server.
Furthermore I added myself as maintainer for the Geogebra package as no maintainers were listed.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@Ma27, thanks for your PR! By analyzing the history of the files in this pull request, we identified @obadz, @zraexy and @zimbatm to be potential reviewers.

@joachifm joachifm merged commit 8204424 into NixOS:master Feb 19, 2017
@Ma27 Ma27 deleted the update/geogebra branch February 19, 2017 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants